Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of POLYFIT / POLYFUNC #974

Merged
merged 13 commits into from
Jun 18, 2021
Merged

Initial commit of POLYFIT / POLYFUNC #974

merged 13 commits into from
Jun 18, 2021

Conversation

hbs
Copy link
Collaborator

@hbs hbs commented Jun 15, 2021

No description provided.

@randomboolean
Copy link
Contributor

Does POLYFIT need to be constrained to bucket indices ?
Maybe we can add the option to fit coefficients wrt timestamps if it finds a boolean flag set at true with the syntax true POLYFIT ? (and accept that with high orders there would be overflow errors)

@randomboolean
Copy link
Contributor

A single-value mapper that uses POLYFIT can also be useful and make the code more readable than a macro or a MACROMAPPER.
This feature would be a function with either syntax:
$list mapper.polynomial
$list POLYMAPPER
$list $returnAMapper POLYFUNC

@randomboolean
Copy link
Contributor

A function that makes a weighted polynomial fit, using a second input numerical GTS could be useful too (for instance to give more weight to more recent values).

ftence
ftence suggested changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@ftence ftence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions are not added to WarpScriptLib.

warp10/src/main/java/io/warp10/script/functions/POLYFIT.java Show resolved Hide resolved
warp10/src/main/java/io/warp10/script/functions/POLYFUNC.java Show resolved Hide resolved
warp10/src/main/java/io/warp10/script/functions/POLYFIT.java Outdated Show resolved Hide resolved
warp10/src/main/java/io/warp10/script/functions/POLYFUNC.java Outdated Show resolved Hide resolved
ftence
ftence suggested changes Jun 17, 2021
View reviewed changes
warp10/src/main/java/io/warp10/script/functions/POLYFUNC.java Outdated
double value = this.func.value(((Number) top).doubleValue());

stack.push(value);
} else if (!(top instanceof Number)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to else.

@hbs hbs merged commit 90bfc53 into senx:master Jun 18, 2021
@ftence ftence mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomboolean randomboolean randomboolean left review comments

@ftence ftence ftence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hbs @randomboolean @ftence