Add better nullability support. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json-schema supports nullability through a type union. However, it can be cumbersome to have to use type unions everywhere. This commit adds better support for nullability: * Any property can declare its nullability with a simple `nullable: true` declaration. * Add a new `scalars_nullable_by_default` config setting.
|
Looks good. |
Previously, once you configured `endpoint_definition_files`, no other config options would affect the endpoints even if they were meant to because the endpoints were already loaded by that point. This changes the endpoint loading so that it's lazy.
- Don't change `type: null` to `type: [null]`. - Don't blow up when there is an actual property named `type`.
myronmarston
added a commit
that referenced
this pull request
Apr 28, 2013
Add better nullability support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-schema supports nullability through a type union.
However, it can be cumbersome to have to use type unions
everywhere. This commit adds better support for nullability:
nullable: truedeclaration.scalars_nullable_by_defaultconfig setting.