Upgrade json schema to latest version #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,10 +217,10 @@ def endpoint_name | |||
|
|
|||
| def validate_data!(data, validate_schema = true) | |||
| if validate_schema | |||
| errors = ::JSON::Validator.fully_validate_schema(schema) | |||
| errors = ::JSON::Validator.fully_validate_schema(schema, version: :draft3) | |||
There was a problem hiding this comment.
We should probably make the version be an attribute of the endpoint. As this currently exists it looks like there's no way to make an endpoint use v4 json schema.
That said, I'm fine with that being declared out of scope if it'll be addressed in a future iteration.
There was a problem hiding this comment.
I'll declare it out of scope for now. There's a $schema key you can use to point to a specific schema version, but I'm not sure how the json-schema gem handles that when also passed an explicit version key.
bkirz
force-pushed
the
upgrade-json-schema
branch
from
68d5734
to
2e72264
Compare
- It's reached End-of-Life and has unpatched security vulnerabilities. - It's no longer supported by our dev tools (chruby/ruby-install)
bkirz
force-pushed
the
upgrade-json-schema
branch
from
45266ea
to
da46e04
Compare
bkirz
added a commit
that referenced
this pull request
Oct 10, 2014
Upgrade json schema to latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using 1.1.1 for a long time, and 2.2.5 brings some fancy new features like strict mode. With this upgrade, we'll be able to depend the newer json-schema version in apps that use interpol.