Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua Script Error on Redis 3.2 #63

Open
icheishvili opened this issue May 31, 2016 · 1 comment
Open

Lua Script Error on Redis 3.2 #63

icheishvili opened this issue May 31, 2016 · 1 comment

Comments

@icheishvili
Copy link

icheishvili commented May 31, 2016 •
edited

On Redis 3.2, this error breaks qless:

Redis::CommandError - ERR Error running script (call to f_3f9682e7ddb462dca8c60a26d5e88ac70c3a49e9): @user_script:925: @user_script: 925: Lua redis() command arguments must be strings or integers :
  redis (3.3.0) lib/redis/client.rb:121:in `call'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/instrumentation/redis.rb:42:in `block in call'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/datastores.rb:111:in `block in wrap'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer.rb:73:in `block in trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer_helpers.rb:82:in `trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer.rb:71:in `trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/datastores.rb:108:in `wrap'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/instrumentation/redis.rb:41:in `call'
  redis (3.3.0) lib/redis.rb:2394:in `block in _eval'
  redis (3.3.0) lib/redis.rb:58:in `block in synchronize'
  /Users/xxx/.rbenv/versions/2.2.3/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
  redis (3.3.0) lib/redis.rb:58:in `synchronize'
  redis (3.3.0) lib/redis.rb:2393:in `_eval'
  redis (3.3.0) lib/redis.rb:2445:in `evalsha'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:44:in `_call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:26:in `block in call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:49:in `handle_no_script_error'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:25:in `call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless.rb:202:in `call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/queue.rb:108:in `put'
@icheishvili icheishvili mentioned this issue May 31, 2016
Closed
@diesse diesse mentioned this issue Jun 21, 2016
Merged
@girasquid girasquid mentioned this issue Jan 13, 2017
Closed
a0s pushed a commit to a0s/qless that referenced this issue Jan 23, 2017
Dirty fix for Check both 'nil' and 'false' in redis.call return value
b0d3566 
This is fast and dirty applying custora#3 to the current qless master branch.
Yes, i know about qless-core :)

See also seomoz/qless-core#63
@evanbattaglia
Copy link
Contributor

As per #64, I believe this is fixed (fixes the issue I had with it anyway) and can be closed, anyone disagree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icheishvili @evanbattaglia