Remove worker client reference. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Qless::Worker does not need a reference to a client. It restrict flexibility by coupling it to one client like this. While it does not normally make sense to do so, we have a case where would like a single worker to pull jobs from queues on multiple qless servers, which works just fine because the queue objects themselves know what client to talk to.
|
It's worth noting this is a breaking change if anyone is calling the Looks good. |
myronmarston
added a commit
that referenced
this pull request
Jan 30, 2013
Remove worker client reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Qless::Worker does not need a reference to a client. It restrict
flexibility by coupling it to one client like this. While it does not
normally make sense to do so, we have a case where would like a
single worker to pull jobs from queues on multiple qless servers,
which works just fine because the queue objects themselves know
what client to talk to.
/cc @proby @dlecocq