Various TTL fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DavidBarts
commented
Oct 1, 2013
DavidBarts
commented
- Utility.parse_time was ignoring time zones. This was causing robots.txt to sometimes get fetched excessively.
- The no-cache Cache-Control: directive should only be honored if it appears "bare", not in no-cache=blah form (in which case it has another meaning).
- If the expires header cannot be parsed, use the default TTL instead of a TTL of 0.
ghost
assigned 
|
Seems reasonable to me, but looks like there are a couple tests that need fixing first. |
| '''Parse a human-readable time into a timestamp''' | ||
| return time.mktime(dateutil.parser.parse(strng).timetuple()) | ||
| '''Parse an HTTP-style (i.e. email-style) time into a timestamp''' | ||
| v = email.utils.parsedate_tz(strng) |
There was a problem hiding this comment.
Was the reason for this switch a matter of strictness? Or to remove the dateutil dependency?
There was a problem hiding this comment.
Dateutil was ignoring time zones and parsing everything as GMT. This was causing robots.txt data to expire too soon or too late, depending on the time zone.
|
OK, the tests pass now. Fixed them to accommodate the changes I made. Coverage is not 100% but it's the same as before I made my edits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.