-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Issues Fixed #178
Minor Issues Fixed #178
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #178 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 1 1
Lines 276 276
Branches 75 75
=======================================
Hits 251 251
Misses 23 23
Partials 2 2
Continue to review full report at Codecov.
|
otherfile/font_wizard.py
Outdated
@@ -58,7 +83,9 @@ def is_ascii(s): | |||
font_name = input("Please enter font name : ") | |||
if font_name in Font_List: | |||
print(Error6) | |||
else: | |||
elif font_name in INVALID_FONT_NAME: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font_name.lower()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. You are right.
otherfile/font_wizard.py
Outdated
@@ -58,7 +83,9 @@ def is_ascii(s): | |||
font_name = input("Please enter font name : ") | |||
if font_name in Font_List: | |||
print(Error6) | |||
else: | |||
elif font_name.lower() in INVALID_FONT_NAME: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion from my part :
I think here we can print Error6
instead of a new error message because it's not possible for us to print all reserved fonts for users.
My suggestion:
if font_name in Font_List or font_name.lower() in INVALID_FONT_NAME:
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
What does this implement/fix? Explain your changes.
font_wizard.py
(bellow fonts)