Minor Issues Fixed #178
Merged
Minor Issues Fixed #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #178 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 1 1
Lines 276 276
Branches 75 75
=======================================
Hits 251 251
Misses 23 23
Partials 2 2
Continue to review full report at Codecov.
|
sepandhaghighi
requested changes
Sep 10, 2021
sepandhaghighi
requested changes
Sep 11, 2021
otherfile/font_wizard.py
Outdated
| @@ -58,7 +83,9 @@ def is_ascii(s): | |||
| font_name = input("Please enter font name : ") | |||
| if font_name in Font_List: | |||
| print(Error6) | |||
| else: | |||
| elif font_name in INVALID_FONT_NAME: | |||
There was a problem hiding this comment.
Yes. You are right.
sepandhaghighi
requested changes
Sep 13, 2021
otherfile/font_wizard.py
Outdated
| @@ -58,7 +83,9 @@ def is_ascii(s): | |||
| font_name = input("Please enter font name : ") | |||
| if font_name in Font_List: | |||
| print(Error6) | |||
| else: | |||
| elif font_name.lower() in INVALID_FONT_NAME: | |||
There was a problem hiding this comment.
Minor suggestion from my part :
I think here we can print Error6 instead of a new error message because it's not possible for us to print all reserved fonts for users.
My suggestion:
if font_name in Font_List or font_name.lower() in INVALID_FONT_NAME:
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
font_wizard.py(bellow fonts)