Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add threshold for numerics #68

Open
seperman opened this issue May 29, 2017 · 1 comment
Open

Feature: Add threshold for numerics #68

seperman opened this issue May 29, 2017 · 1 comment

Comments

@seperman
Copy link
Owner

We already have ignore significant digits but what we need to add is a threshold for numerics so that it ignores the diff if it is within the threshold.

For example if threshold is 1% then the diff between 1000 and 1001 should be ignored.

@seperman seperman added this to the V3.5 milestone May 29, 2017
@seperman
Copy link
Owner Author

seperman commented Aug 4, 2017

This feature has turned out to be tricky to implement when ignore_order=True.

Option1: Have some sort of threshold that rounds up numbers the way we are already doing it with significant digits, except do it on the other side of the decimal point too.

Option 2: We can also add 2 other parameters when ignore_order=False to basically use Python3's math.isclose(). If we do that then we will have 2 parameters that work only when ignore_order=False.

We can add both of these options.
What do you guys think? @Bernhard10 @victorhahncastell

@seperman seperman removed this from the V3.5 milestone Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant