Add support for local / personnal aliases #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def is_local(self): | ||
| return self.local | ||
|
|
||
| def is_selected(self, exclude_ignored, exclude_local): |
There was a problem hiding this comment.
A comment that explains what this method is doing would be great
|
Can we go on with this one? It's ready to be merge no? |
|
It needs some tests. |
added 5 commits
July 30, 2014 20:44
|
Thanks! |
|
Enfin! Bravo! Gilles a-t-il écrit ces tests finalement? On Wed, Jul 30, 2014 at 11:24 PM, Sylvain Fankhauser <
David Jeanmonod |
|
7352851 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve #24