-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE - Async networking #67
Conversation
…commits are signed
I still have an issue with the github workflow, claiming that it can't find
|
Add Examples
@@ -17,6 +17,7 @@ pub mod ledger; | |||
pub mod ledger_closed; | |||
pub mod ledger_current; | |||
pub mod ledger_data; | |||
#[allow(clippy::result_large_err)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to do this?
@@ -9,6 +9,7 @@ | |||
|
|||
pub mod exceptions; | |||
#[cfg(feature = "ledger")] | |||
#[allow(clippy::too_many_arguments)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow these exceptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I allowed too_many_arguments
because the new
methods have a lot of parameters. What would be your suggestion to resolve the clippy warning?
…ientEmbeddedWebsocket
…ientEmbeddedWebsocket
Closed in favor of #70 |
High Level Overview of Change
Adds async networking abilities:
Due to the milestones complexity, a new crate em-as-net will be created. For a high level overview of the state of em-as-net see this issue:
Important to notice: At the time of writing the crate is still missing
TlsConnection
to establish safe connections.The PR also contains smaller improvements like making ˋnewˋ methods public and importing the ˋToStringˋ trait in the ˋErr!ˋ macro instead of importing it in every file that uses the macro.
TODO
TlsConnection
in em-as-netType of Change
Test Plan
A code sample was added to
tests/common.rs