Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncWebsocketClient #70

Merged
merged 19 commits into from
Aug 28, 2023
Merged

Add AsyncWebsocketClient #70

merged 19 commits into from
Aug 28, 2023

Conversation

LimpidCrypto
Copy link
Collaborator

@LimpidCrypto LimpidCrypto commented Aug 14, 2023

High Level Overview of Change

This PR is a replacement of #67 to fix the incorrect base branch of #67 . The changes are basically the same.

Adds an AsyncWebsocketClient to establish a websocket connection to a XRPL node.
Features:
"net" and "embedded-websocket": To establish a websocket connection the crate embedded-websocket is used.
"net" and "tungstenite": To establish a websocket connection the crate tokio-tungstenite is used.

The PR also updates some dependencies.

Type of Change

  • New feature (non-breaking change which adds functionality)

TODO:

  • Handle unwraps

@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Aug 14, 2023
@LimpidCrypto LimpidCrypto added this to the Add clients milestone Aug 14, 2023
@LimpidCrypto LimpidCrypto self-assigned this Aug 14, 2023
@LimpidCrypto LimpidCrypto mentioned this pull request Aug 14, 2023
4 tasks
This was linked to issues Aug 14, 2023
@sephynox
Copy link
Owner

We should probably do package updates in a separate PR of their own in the future.

@sephynox
Copy link
Owner

We should fix the deprecation warnings such as use of deprecated method chrono::TimeZone::timestamp: use timestamp_opt() instead.

examples/std/src/bin/tokio/net/send_request.rs Outdated Show resolved Hide resolved
rust-toolchain Outdated Show resolved Hide resolved
tests/integration/clients/mod.rs Outdated Show resolved Hide resolved
tests/common/mod.rs Outdated Show resolved Hide resolved
tests/common/mod.rs Outdated Show resolved Hide resolved
src/asynch/clients/async_websocket_client.rs Show resolved Hide resolved
@LimpidCrypto LimpidCrypto merged commit d7fb5e6 into dev Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add clients private ˋnewˋ methods
2 participants