Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abspath needs to be normalized before attempting to find substring in… #12

Merged
merged 4 commits into from Aug 3, 2020

Conversation

zacharycarter
Copy link
Contributor

@zacharycarter zacharycarter commented Jul 16, 2020

… path being watched. There's also a memory leak in dmon.h on OSX.

Fixes #11 & #13

@zacharycarter
Copy link
Contributor Author

@septag - I'm not sure what the contribution guidelines are for this project, or if you are looking for others to contribute fixes. I found two issues with the directory monitoring code on OSX, which this PR addresses. I'm guessing you're quite busy, but whenever you have time to review these changes, please let me know if you'd like me to redo the PR or if you have any suggestions for changes.

Otherwise I'll just close this and keep the changes in my fork.

Thanks!

@septag
Copy link
Owner

septag commented Jul 31, 2020

Hi @zacharycarter ,
I'm very sorry dude, yeah, I was quite busy these past weeks, I couldn't check your changes. Luckily, I have some time now, I will check this tomorrow and get back to you.

Thanks

@zacharycarter
Copy link
Contributor Author

Hi @zacharycarter ,
I'm very sorry dude, yeah, I was quite busy these past weeks, I couldn't check your changes. Luckily, I have some time now, I will check this tomorrow and get back to you.

Thanks

Thanks @septag! I figured you might be, especially with the Farcry announcement. No huge rush - just wanted to ensure you were interested in PRs.

@septag septag merged commit f85cb1c into septag:master Aug 3, 2020
@septag
Copy link
Owner

septag commented Aug 3, 2020

looks good to me, thank you very much!

I figured you might be, especially with the Farcry announcement. No huge rush - just wanted to ensure you were interested in PRs.

haha, yeah, but I'm not working on that project. :) The main story is that MacOS is not my main dev platform, I have this shitty old iMac mini for dev, after the OS update, many things got messed up on it, so I'm just not that hyped to work on it, especially if I have not much time.

@zacharycarter
Copy link
Contributor Author

@RUSshy it's already been merged. I'll leave it to septag to apply the change to the dmon repo if they want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reloading of shader doesn't seem to work on macOS
2 participants