Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify build error for rolling/humble #60

Merged
merged 1 commit into from
May 16, 2022

Conversation

wep21
Copy link

@wep21 wep21 commented May 8, 2022

I modified CMakeLists.txt to support rolling/humble distribution.
See https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html.

Deprecation of rosidl_target_interfaces()[](https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html#deprecation-of-rosidl-target-interfaces)
The CMake function rosidl_target_interfaces() has been deprecated, and now issues a CMake warning when called. Users wanting to use messages/services/actions in the same ROS package that generated them should instead call rosidl_get_typesupport_target() and then target_link_libraries() to make their targets depend on the returned typesupport target. See https://github.com/ros2/rosidl/pull/606 for more details, and https://github.com/ros2/demos/pull/529 for an example of using the new function.

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented May 8, 2022

@tibordome Could you reviwe this PR and do bloom-release toward rolling/humble distribution?

@tibordome tibordome merged commit 2259d5c into septentrio-gnss:ros2 May 16, 2022
@wep21 wep21 deleted the support-rolling branch May 16, 2022 11:28
@wep21
Copy link
Author

wep21 commented May 16, 2022

@tibordome Thank you for merging. I appreciate it if you could do bloom-release toward both rolling and humble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants