Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage for aptly_snapshot.rb #143

Merged

Conversation

msabramo
Copy link
Contributor

Cover 4 remaining lines in aptly_snapshot.rb, bringing coverage of that file to 100%! 😄

@@ -196,6 +215,20 @@ def test_snapshot_create_ref
'testrepo_snap_create_ref').code.to_s
end

def test_snapshot_create_ref_exception
raises_exception = -> (uri, options) do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused block argument - uri. If it's necessary, use _ or _uri as an argument name to indicate that it won't be used. Also consider using a proc without arguments instead of a lambda if you want it to accept any arguments but don't care about them.
Unused block argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used. Also consider using a proc without arguments instead of a lambda if you want it to accept any arguments but don't care about them.
Use the lambda method for multi-line lambdas.

@msabramo msabramo force-pushed the increased_coverage_for_aptly_snapshot branch 2 times, most recently from ef91349 to dadea99 Compare July 25, 2016 02:06
@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.6%) to 99.45% when pulling dadea99 on msabramo:increased_coverage_for_aptly_snapshot into 153bb55 on sepulworld:master.

Cover 4 remaining lines in `aptly_snapshot.rb`, bringing coverage of
that file to 100%! 😄
@msabramo msabramo force-pushed the increased_coverage_for_aptly_snapshot branch from dadea99 to 50b156e Compare July 25, 2016 02:07
@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.6%) to 99.45% when pulling 50b156e on msabramo:increased_coverage_for_aptly_snapshot into 153bb55 on sepulworld:master.

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage increased (+0.6%) to 99.45% when pulling 50b156e on msabramo:increased_coverage_for_aptly_snapshot into 153bb55 on sepulworld:master.

@sepulworld
Copy link
Owner

Woot! 100%! Ty!

@sepulworld sepulworld merged commit 8bab6d8 into sepulworld:master Jul 26, 2016
@msabramo msabramo deleted the increased_coverage_for_aptly_snapshot branch August 2, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants