-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE, TEST] Making find_deletions write to an output file and not to std::out. And adding tests. #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Could you please rebase on the current master? And connect the PR to the related issue (Button at the bottom of this page.). And write at least resolves #ISSUENUMBER
in the description of this PR.
Most of my requests are more like discussion points.
0889b34
to
07ef2ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thank you very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest something that does not need to be changed or part of this PR:
You go from functions foo()
that print to std::cout to function foo(std::ofstream & out_file)
that prints to a file. If you would do
template<typename stream_type>
void foo(stream_type & stream)
{
stream << // ...
}
You can pass either a file OR std::cout. Writing to an dedicated output file is always very helpful in most application but I find sometimes, when writing pipelines, it can be very handy if the file can also be written to std::cout. This of course depends on your App and whether you think it may or may not be executed as part of a pipeline. If not you can ignore my suggestion, if so you might want to consider writing to cout
unless a output_path is given. :) Just ideas
Note that there is also a output_stream seqan3 concept for checking that is has the <<
operator.
07ef2ad
to
5a9d1d7
Compare
5a9d1d7
to
7c0e2a4
Compare
Resolves 1/2 of #21