Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] tidy up tests and add all method combination tests in a new file #73

Merged
merged 3 commits into from
Mar 1, 2021
Merged

[TEST] tidy up tests and add all method combination tests in a new file #73

merged 3 commits into from
Mar 1, 2021

Conversation

Irallia
Copy link
Collaborator

@Irallia Irallia commented Feb 23, 2021

Resolves #69

@Irallia Irallia self-assigned this Feb 23, 2021
@Irallia
[TEST] tidy up tests and add all method combination tests in a separa…
c210808 
…te file

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the TEST/add_tests_for_input_parameters branch from a2392f0 to c210808 Compare February 23, 2021 15:34
@Irallia Irallia requested review from a team and SGSSGene and removed request for a team February 23, 2021 17:09
SGSSGene
SGSSGene requested changes Feb 24, 2021
View reviewed changes
Copy link

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some for loops are broken.

src/detect_breakends/junction_detection.cpp Outdated Show resolved Hide resolved
src/detect_breakends/junction_detection.cpp Outdated Show resolved Hide resolved
src/detect_breakends/junction_detection.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Show resolved Hide resolved
@Irallia
Copy link
Collaborator Author

Irallia commented Feb 25, 2021

Thanks for the good suggestions for improvement!

SGSSGene
SGSSGene approved these changes Feb 25, 2021
View reviewed changes
Copy link

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Irallia
Apply 1. Review
760cf59 
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the TEST/add_tests_for_input_parameters branch from 36cd55f to 760cf59 Compare February 25, 2021 13:49
joshuak94
joshuak94 requested changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@joshuak94 joshuak94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things! Nice work~

test/api/junction_detection_methods_test.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Show resolved Hide resolved
test/api/junction_detection_methods_test.cpp Outdated Show resolved Hide resolved
test/api/junction_detection_test.cpp Outdated Show resolved Hide resolved
@Irallia
Apply 2. Review
2c7745f 
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia merged commit 5071ed1 into seqan:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

@joshuak94 joshuak94 joshuak94 approved these changes

Assignees

@Irallia Irallia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Write tests for different input parameters of detect_breakends.
3 participants
@Irallia @SGSSGene @joshuak94