Using less space during construction #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This also changes the way that a search with an reversed index is working, so no reversing of the text is required anymore. - Requires to set the numbers of thread used for suffix array construction.
Co-authored-by: Hannes Hauswedell <h2+github.com@fsfe.org>
SGSSGene
force-pushed
the
fix/less_space_construction
branch
from
dc1c1c7
to
2196690
Compare
|
@SGSSGene can we merge this from your POV? |
|
Yes, this is good to go. if this PR is being merged, PR 208 - multithreading can also be closed, since this one includes it. |
SGSSGene
force-pushed
the
fix/less_space_construction
branch
from
3e5c65e
to
d8286ae
Compare
|
Ah, I pushed the commits to the wrong branch of yours, but I see you have included them here now! |
h-2
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fmindex collection, which now uses less space, when constructing fm-indices