[fix] alignment bug #222
[fix] alignment bug #222
Conversation
h-2
force-pushed
the
align_bug
branch
2 times, most recently
from
ecccc41
to
742533a
Compare
src/search_misc.hpp
Outdated
| @@ -46,7 +46,7 @@ struct QueryException : public std::runtime_error | |||
| inline int _bandSize(uint64_t const seqLength) | |||
There was a problem hiding this comment.
Should the return type here also be int64_t?
There was a problem hiding this comment.
Done. I don't think this affects anything though.
src/search_algo.hpp
Outdated
| // pairwise "swallow" from right to left | ||
| for (auto it = matches.rbegin(); it < matches.rend() - 1; ++it) | ||
| { | ||
| Match & l = *it; |
There was a problem hiding this comment.
Given that the comment says from right to left, I understood it in a way that we are still "looking" at the vector the same way as before. However, now that we are backwards iterating technically l is to the right of r in the sense of that comment and it confused me naming-wise when I tried to understand what is happening (because it does not match the l and r in the loop before order-wise). Can we find a different way of naming this that is more intuitive?
There was a problem hiding this comment.
That's a good point. I have switched r and l. Is that OK?
tests still need fixing