Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce seqan3::literals #287

Closed
14 tasks
marehr opened this issue Feb 8, 2021 · 1 comment · Fixed by seqan/seqan3#2568
Closed
14 tasks

Reintroduce seqan3::literals #287

marehr opened this issue Feb 8, 2021 · 1 comment · Fixed by seqan/seqan3#2568
Assignees

Comments

@marehr
Copy link
Member

marehr commented Feb 8, 2021

Description

See old discussion why we abandoned it seqan/seqan3#152.

Acceptance Criteria

  • test 1
  • test 2
  • test 3

Tasks

  • task 1
  • task 2
  • task 3

Definition of Done

  • Implementation and design approved
  • Unit tests pass
  • Test coverage = 100%
  • Microbenchmarks added and/or affected microbenchmarks < 5% performance drop
  • API documentation added
  • Tutorial/teaching material added
  • Test suite compiles in less than 30 seconds (on travis)
  • Changelog entry added
@marehr marehr changed the title Re-introduce seqan3::literal Re-introduce seqan3::literals Feb 8, 2021
@marehr
Copy link
Member Author

marehr commented Feb 8, 2021

2021-02-08 Core Meeting

We miss seqan3::literals. We think the original issue was that seqan3::literals (in plural because the std names it also plural) wasn't defined as an inline namespace. S.t. you needed to "import" seqan namespaces twice:

in the old times:

using namespace seqan3;
using namespace seqan3::literal;

"ACGT"_dna4

Now:

using namespace seqan3::literals;

"ACGT"_dna4

or

using namespace seqan3;

"ACGT"_dna4

The main problem is that we discourage to use using namespace seqan3;, but if you want to use a literal, you need to import it with a weird syntax using seqan3::operator""_aa10li;. Now you can use using namespace seqan3::literals;

Tests should still import it explicitly instead of using namespace seqan3::literals;. Snippets should use using namespace seqan3::literals;.

We sometimes have

 * \attention
 * All seqan3 literals are in the namespace seqan3!

these should be removed without replacement.

namespace seqan3
{
inline namespace literals
{
auto operator""_aa10li(...);
} // namespace literals
} // namespace seqan3

@marehr marehr added this to the 3.0.3 Release Sprint milestone Apr 12, 2021
@eseiler eseiler self-assigned this Apr 27, 2021
@eseiler eseiler changed the title Re-introduce seqan3::literals Reintroduce seqan3::literals Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants