Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Reintroduce seqan3::literals #2568

Merged
merged 13 commits into from
Apr 28, 2021
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 27, 2021

Resolves seqan/product_backlog#287

Since I needed to change all the alphabet snippets, I also streamlined them and added missing ones.
I recommend reviewing commit-by-commit as most changes are the same across different modules.

@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/EQp9mD7w6QG9Zwesooh1NKTrdzTh
✅ Preview: https://seqan3-git-fork-eseiler-misc-literals-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #2568 (4a0c374) into master (5e290ff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10539    10539           
=======================================
  Hits        10353    10353           
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/alphabet/aminoacid/aa10li.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/aminoacid/aa10murphy.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/aminoacid/aa20.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/aminoacid/aa27.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/cigar/cigar.hpp 91.30% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna15.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna16sam.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna3bs.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna4.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/nucleotide/dna5.hpp 100.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e290ff...4a0c374. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a huge review, thanks for your work.
I have some questions that may just need an explanation and no changes.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

test/snippet/alphabet/cigar/cigar_operation.cpp Outdated Show resolved Hide resolved
Co-authored-by: Lydia Buntrock <irallia@chrigelyra.de>
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

seq_l = 'G'_dna4;
// Modify via structured bindings and references:
auto & [ sequence_letter, quality_letter ] = letter;
sequence_letter = 'G'_dna4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: create a follow-up issue

@eseiler eseiler merged commit 9472019 into seqan:master Apr 28, 2021
@eseiler eseiler deleted the misc/literals branch May 14, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reintroduce seqan3::literals
3 participants