-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Reintroduce seqan3::literals #2568
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/EQp9mD7w6QG9Zwesooh1NKTrdzTh |
Codecov Report
@@ Coverage Diff @@
## master #2568 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 269 269
Lines 10539 10539
=======================================
Hits 10353 10353
Misses 186 186
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a huge review, thanks for your work.
I have some questions that may just need an explanation and no changes.
test/snippet/alphabet/composite/alphabet_tuple_base_subtype_construction.cpp
Outdated
Show resolved
Hide resolved
test/snippet/alphabet/composite/alphabet_tuple_base_subtype_construction.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
Co-authored-by: Lydia Buntrock <irallia@chrigelyra.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty
test/snippet/alphabet/composite/alphabet_tuple_base_subtype_construction.cpp
Outdated
Show resolved
Hide resolved
seq_l = 'G'_dna4; | ||
// Modify via structured bindings and references: | ||
auto & [ sequence_letter, quality_letter ] = letter; | ||
sequence_letter = 'G'_dna4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: create a follow-up issue
Resolves seqan/product_backlog#287
Since I needed to change all the alphabet snippets, I also streamlined them and added missing ones.
I recommend reviewing commit-by-commit as most changes are the same across different modules.