Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Jörg Winkler <j.winkler@fu-berlin.de>
  • Loading branch information
rrahn and joergi-w committed Dec 5, 2019
1 parent 27997fb commit f847f5a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions include/seqan3/alignment/pairwise/alignment_algorithm.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class alignment_algorithm :
* \details
*
* Expects that the size of the batch is less or equal than the number of alignments that can be computed within one
* simd vector. Applies a Array-of-Structures (AoS) to Structure-of-Arrays (SoA) transformation by storing one
* simd vector. Applies an Array-of-Structures (AoS) to Structure-of-Arrays (SoA) transformation by storing one
* column of the batch as a simd vector.
*/
template <typename sequence_range_t>
Expand Down Expand Up @@ -371,7 +371,7 @@ class alignment_algorithm :
* \param[in] sequence2 The second sequence.
*/
template <typename sequence1_t, typename sequence2_t>
auto compute_matrix(sequence1_t & sequence1, sequence2_t & sequence2)
void compute_matrix(sequence1_t & sequence1, sequence2_t & sequence2)
//!\cond
requires !traits_t::is_banded
//!\endcond
Expand Down Expand Up @@ -402,7 +402,7 @@ class alignment_algorithm :

//!\overload
template <typename sequence1_t, typename sequence2_t>
auto compute_matrix(sequence1_t & sequence1, sequence2_t & sequence2, static_band const & band)
void compute_matrix(sequence1_t & sequence1, sequence2_t & sequence2, static_band const & band)
//!\cond
requires traits_t::is_banded
//!\endcond
Expand Down Expand Up @@ -648,7 +648,7 @@ class alignment_algorithm :
requires traits_t::is_vectorised
//!\endcond
constexpr auto make_alignment_result(index_range_t && index_range,
[[maybe_unused]] sequence1_range_t && sequence1_range,
sequence1_range_t && sequence1_range,
[[maybe_unused]] sequence2_range_t && sequence2_range)
{
using sequence1_t = std::ranges::range_value_t<sequence1_range_t>;
Expand Down
4 changes: 2 additions & 2 deletions include/seqan3/alignment/pairwise/alignment_configurator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -426,9 +426,9 @@ struct alignment_configurator
* \details
*
* The correct scoring scheme is selected based on the vectorisation mode. If no vectorisation is enabled, the
* scoring scheme is the one configured in seqan3::align_config::scoring. If vectorisation is enabled, than the
* scoring scheme is the one configured in seqan3::align_config::scoring. If vectorisation is enabled, then the
* appropriate scoring scheme for the vectorised alignment algorithm is selected. This involves checking whether the
* passed scoring scheme is a matrix or a simple scoring scheme, which has only mistmatch and match costs.
* passed scoring scheme is a matrix or a simple scoring scheme, which has only mismatch and match costs.
*/
template <typename function_wrapper_t, typename config_t>
static constexpr function_wrapper_t configure_scoring_scheme(config_t const & cfg);
Expand Down
2 changes: 1 addition & 1 deletion include/seqan3/alignment/pairwise/detail/concept.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ SEQAN3_CONCEPT align_pairwise_single_input =
* whose reference type is an lvalue reference and the range itself models std::ranges::viewable_range or
* the reference type is a prvalue and it models seqan3::detail::align_pairwise_single_input.
* This covers all typical use cases:
* a) A lvalue range, whose reference type is a tuple like lvalue reference,
* a) An lvalue range, whose reference type is a tuple like lvalue reference,
* b) A range, whose reference type is a tuple over viewable ranges.
* This covers also transforming and non-transforming views (e.g. views::zip, or views::take).
* Only a temporary non-view range piped with views::persist can't be handled securely.
Expand Down

0 comments on commit f847f5a

Please sign in to comment.