[MISC] rename view:: to views:: #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-2
force-pushed
the
infra/rename_views
branch
2 times, most recently
from
f014963
to
ac3cacb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
+ Coverage 97.31% 97.36% +0.04%
==========================================
Files 221 221
Lines 8874 8912 +38
==========================================
+ Hits 8636 8677 +41
+ Misses 238 235 -3
Continue to review full report at Codecov.
|
rrahn
requested changes
Sep 10, 2019
There was a problem hiding this comment.
I took the initiative and tried to spot possible alignment errors, or include issues, e.g. includes that are not used by snippets etc. That is of course not part of this PR, but otherwise it will be hard to track down these things. So better fix them right now.
| @@ -26,7 +26,7 @@ TYPED_TEST_CASE_P(bi_fm_index_cursor_collection_test); | |||
| TYPED_TEST_P(bi_fm_index_cursor_collection_test, begin) | |||
| { | |||
| std::vector<std::vector<dna4>> text{"AACGATCGGA"_dna4, "AACGATCGGA"_dna4}; | |||
| auto rev_text = text | view::deep{std::view::reverse} | view::deep{view::persist}; | |||
| auto rev_text = text | views::deep{std::views::reverse} | views::deep{views::persist}; | |||
There was a problem hiding this comment.
potentially missing includes for deep and persist
| @@ -37,7 +37,7 @@ inline void test_search_hamming(auto it, text_t const & text, auto const & searc | |||
| using char_t = typename text_t::value_type; | |||
|
|
|||
| uint64_t const pos = std::rand() % (text.size() - query_length + 1); | |||
| text_t const orig_query = text | view::slice(pos, pos + query_length); | |||
| text_t const orig_query = text | views::slice(pos, pos + query_length); | |||
There was a problem hiding this comment.
potentially missing includes for slice view
h-2
force-pushed
the
infra/rename_views
branch
from
e46b04f
to
8c65076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only concatenated_sequences has interesting changes