[FIX] visibility errors on gcc - std #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 221 221
Lines 8935 8935
=======================================
Hits 8720 8720
Misses 215 215Continue to review full report at Codecov.
|
joergi-w
approved these changes
Oct 22, 2019
smehringer
requested changes
Oct 22, 2019
| template <contiguous_iterator iterator_t, sized_sentinel_for<iterator_t> sentinel_t> | ||
| requires is_convertible_v<remove_reference_t<iter_reference_t<iterator_t>>(*)[], element_type(*)[]> && | ||
| template <contiguous_iterator iterator_t, typename sentinel_t> | ||
| requires sized_sentinel_for<sentinel_t, iterator_t> && |
There was a problem hiding this comment.
doxugen \\!cond missing for all of them
There was a problem hiding this comment.
can't do this, because the complete file is //!cond; see line17 to 425
smehringer
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #1228
fixes partially #1317