[FIX] Missing queries in single element text collections #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svnbgnk
approved these changes
Oct 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
+ Coverage 97.48% 97.48% +<.01%
==========================================
Files 218 218
Lines 8680 8682 +2
==========================================
+ Hits 8462 8464 +2
Misses 218 218
Continue to review full report at Codecov.
|
rrahn
requested changes
Oct 23, 2019
smehringer
reviewed
Oct 24, 2019
rrahn
requested changes
Oct 24, 2019
CHANGELOG.md
Outdated
| @@ -72,6 +72,8 @@ If possible, provide tooling that performs the changes, e.g. a shell-script. | |||
| ## Notable Bug-fixes | |||
|
|
|||
| * Copying and moving the `seqan3::fm_index` and `seqan3::bi_fm_index` now work properly. | |||
| * Searching in the `seqan3::fm_index` and `seqan3::bi_fm_index` constructed from a text collection containg a single | |||
There was a problem hiding this comment.
Suggested change
| * Searching in the `seqan3::fm_index` and `seqan3::bi_fm_index` constructed from a text collection containg a single | |
| * Searching in the `seqan3::fm_index` and `seqan3::bi_fm_index` constructed from a text collection containing a single |
| @@ -303,6 +304,10 @@ class fm_index | |||
| | views::join(delimiter) | |||
| | views::to<std::vector<uint8_t>>; | |||
|
|
|||
| // we need at least one delimiter | |||
| if (std::ranges::distance(text) == 1) | |||
There was a problem hiding this comment.
just always add the delimiter makes the code a little easier I guess. And it shouldn't hurt.
There was a problem hiding this comment.
Somewhere, something breaks 🤷♂
rrahn
approved these changes
Oct 25, 2019
|
ci is broken? |
eseiler
force-pushed
the
fix/fm
branch
5 times, most recently
from
638751a
to
ae89ae9
Compare
|
@rrahn Travis runs through, but won't tell us here. |
rrahn
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1315