Feature - Make the score type configurable through the result config object #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehringer
force-pushed
the
alignment_misc
branch
5 times, most recently
from
ea9cc3e
to
2756e71
Compare
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 97.52% 97.52% +<.01%
==========================================
Files 226 226
Lines 8778 8780 +2
==========================================
+ Hits 8561 8563 +2
Misses 217 217
Continue to review full report at Codecov.
|
marehr
reviewed
Nov 13, 2019
smehringer
force-pushed
the
alignment_misc
branch
from
2756e71
to
8aabcdc
Compare
marehr
reviewed
Nov 13, 2019
| EXPECT_TRUE((std::is_same_v<decltype(std::declval<_t>().id()), uint32_t>)); | ||
| EXPECT_TRUE((std::is_same_v<decltype(std::declval<_t>().score()), int32_t>)); | ||
| } | ||
|
|
||
| { // test case II | ||
| auto cfg = align_cfg::edit | align_cfg::result{with_score}; |
There was a problem hiding this comment.
can't you make this one case I and ...
(or you have to change the numbering // test case II -> // test case I, // test case III)
| @@ -63,6 +55,18 @@ TEST(alignment_selector, align_result_selector_with_list) | |||
| } | |||
| } | |||
|
|
|||
| TEST(alignment_selector, align_result_selector_using_score_type) | |||
There was a problem hiding this comment.
I prefer single tests for single cases so I just removed the documentation from above. It just states the obvious anyway..
smehringer
force-pushed
the
alignment_misc
branch
from
8aabcdc
to
46f296b
Compare
…ome of the alignment test templates.
smehringer
force-pushed
the
alignment_misc
branch
from
46f296b
to
8119397
Compare
|
The snippets are failing: https://travis-ci.org/seqan/seqan3/jobs/618589436#L5802 |
marehr
approved these changes
Dec 1, 2019
|
The snippet failing is still a thing. |
… align_result_selector change the if clause to an static assert.
smehringer
force-pushed
the
alignment_misc
branch
from
8119397
to
cc9e158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.