Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Switch from uppercase seqan3::field names to lower case. #1421

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

smehringer
Copy link
Member

@smehringer smehringer commented Dec 12, 2019

Resolves #1422

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1421 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1421   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         232      232           
  Lines        8825     8825           
=======================================
  Hits         8613     8613           
  Misses        212      212
Impacted Files Coverage Δ
.../seqan3/io/sequence_file/output_format_concept.hpp 100% <ø> (ø) ⬆️
include/seqan3/io/structure_file/input.hpp 100% <ø> (ø) ⬆️
...clude/seqan3/io/alignment_file/format_sam_base.hpp 98.1% <ø> (ø) ⬆️
include/seqan3/io/sequence_file/format_fastq.hpp 98.41% <ø> (ø) ⬆️
include/seqan3/io/sequence_file/format_embl.hpp 97.46% <ø> (ø) ⬆️
.../seqan3/io/structure_file/input_format_concept.hpp 100% <ø> (ø) ⬆️
include/seqan3/io/sequence_file/input_options.hpp 100% <ø> (ø) ⬆️
...seqan3/io/alignment_file/output_format_concept.hpp 100% <ø> (ø) ⬆️
include/seqan3/io/alignment_file/header.hpp 100% <ø> (ø) ⬆️
include/seqan3/io/sequence_file/format_fasta.hpp 97.26% <ø> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb818b...6a63372. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, I have cross-checked all the field names.

USER_DEFINED_6 SEQAN3_DEPRECATED_310, //!< Please use the field name in lower case.
USER_DEFINED_7 SEQAN3_DEPRECATED_310, //!< Please use the field name in lower case.
USER_DEFINED_8 SEQAN3_DEPRECATED_310, //!< Please use the field name in lower case.
USER_DEFINED_9 SEQAN3_DEPRECATED_310, //!< Please use the field name in lower case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well since this is actually already used rather often, I think it is important to provide a clear message to the user. Additionally this does not hurt much, does it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrahn Do you agree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is fine.

Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one open question.

@rrahn rrahn merged commit b1851ca into seqan:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IO] Change record seqan3::fields to lower case
4 participants