Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Rename the index char_type to alphabet_type. #1433

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

smehringer
Copy link
Member

Resolves #1432

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #1433 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1433   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         232      232           
  Lines        8831     8831           
=======================================
  Hits         8619     8619           
  Misses        212      212
Impacted Files Coverage Δ
include/seqan3/search/fm_index/fm_index.hpp 100% <ø> (ø) ⬆️
include/seqan3/search/fm_index/bi_fm_index.hpp 100% <ø> (ø) ⬆️
...lude/seqan3/search/fm_index/bi_fm_index_cursor.hpp 100% <100%> (ø) ⬆️
include/seqan3/search/fm_index/fm_index_cursor.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e09b3...0371c79. Read the comment docs.

@smehringer
Copy link
Member Author

sorry about the force push. I forgot to push that one before requesting a review

Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rrahn rrahn merged commit 4935cca into seqan:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename fm_index members char to alphabet
3 participants