[MISC] Replace seqan3::const_reference_t with std one #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 237 238 +1
Lines 9057 9066 +9
=======================================
+ Hits 8847 8856 +9
Misses 210 210
Continue to review full report at Codecov.
|
marehr
approved these changes
Apr 9, 2020
marehr
requested review from
a team and
smehringer
and removed request for
a team
smehringer
reviewed
Apr 11, 2020
There was a problem hiding this comment.
The change LGTM.
@marehr Why aren't we removing these tests since no seqan3 functionality is used anymore?
We don't ned to test the standard?
|
@smehringer good point, we should do this afterwards. I added this as acceptance criteria. |
wvdtoorn
added a commit
to wvdtoorn/seqan3
that referenced
this pull request
Apr 15, 2020
…eqan#1729) * [MISC] Replace seqan3::const_reference_t with std ones * [MISC] Remove double const_reference_ tests * Bring back container test and style fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #1549.
Split into two commits for readability.