[FIX] Alignment score types should be signed #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irallia
force-pushed
the
BUG/alignment/assert_using_an_unsigned_score_type
branch
from
caf0a2d
to
6949b77
Compare
Irallia
requested review from
a team and
simonsasse
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 254 254
Lines 9568 9568
=======================================
Hits 9349 9349
Misses 219 219
Continue to review full report at Codecov.
|
eseiler
requested review from
a team and
smehringer
and removed request for
a team
smehringer
requested changes
Jun 15, 2020
CHANGELOG.md
Outdated
| @@ -102,6 +102,8 @@ Note that 3.1.0 will be the first API stable release and interfaces in this rele | |||
| * When invoking the alignment algorithm with a user defined thread count using the `seqan3::align_cfg::parallel` | |||
| configuration element, `std::thread::hardware_concurrency()` many threads were always spawned. This is now fixed and | |||
| only the specified number of threads will be spawned ([\#1854](https://github.com/seqan/seqan3/pull/1854)). | |||
| * Using an unsigned `score_type` throws a static assert, since gaps and mismatches have negative scores and thus need a | |||
There was a problem hiding this comment.
Suggested change
| * Using an unsigned `score_type` throws a static assert, since gaps and mismatches have negative scores and thus need a | |
| * Using an unsigned `score_type` is prevented with a static assert, since gaps and mismatches have negative scores and thus need a |
| static_assert(std::is_signed_v<score_type>, | ||
| "The alignment algorithm cannot be computed with an unsigned type as the score type. If you " | ||
| "explicitly want an unsigned type as the score type, please submit a feature request explaining the " | ||
| "proposed use case on our github page."); |
There was a problem hiding this comment.
Suggested change
| "proposed use case on our github page."); | |
| "your specific use case on our github page: github.com/seqan/seqan3.git."); |
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Irallia
force-pushed
the
BUG/alignment/assert_using_an_unsigned_score_type
branch
from
6949b77
to
b9d043f
Compare
smehringer
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1867