Range sequence concept

[smehringer]

Part of seqan/product_backlog#60

[rrahn]

Only some minor suggestions 💅 , otherwise lgtm 👍

[marehr]

2020-06-15 Core-Meeting

The Problem:

The sequence concept name has a different from the sequence_container concept. sequence does mean a biological sequence and sequence_container is a named requirement of the standard (see https://en.cppreference.com/w/cpp/named_req/SequenceContainer).

seqan3/include/seqan3/range/container/concept.hpp

Lines 144 to 146 in 22d1a70

	template <typename type>
	SEQAN3_CONCEPT sequence_container = requires (type val, type val2, type const cval)
	{

Resolution:

We decided some time ago that we want to get rid of all the container concepts that would solve this problem.

Follow-up https://github.com/orgs/seqan/projects/4#card-40096824

[codecov]

Codecov Report

Merging #1898 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   97.63%   97.75%   +0.12%     
==========================================
  Files         249      252       +3     
  Lines        9481     9551      +70     
==========================================
+ Hits         9257     9337      +80     
+ Misses        224      214      -10     

Impacted Files	Coverage Δ
...ment/aligned_sequence/aligned_sequence_concept.hpp	100.00% <ø> (ø)
include/seqan3/core/detail/debug_stream_range.hpp	100.00% <100.00%> (ø)
.../search/detail/unidirectional_search_algorithm.hpp	98.57% <0.00%> (-1.43%)	⬇️
include/seqan3/core/simd/view_to_simd.hpp	91.52% <0.00%> (-1.40%)	⬇️
...e/seqan3/search/detail/search_scheme_algorithm.hpp	93.98% <0.00%> (-0.52%)	⬇️
...de/seqan3/argument_parser/detail/version_check.hpp	92.56% <0.00%> (-0.18%)	⬇️
include/seqan3/core/math.hpp	100.00% <0.00%> (ø)
include/seqan3/alphabet/concept.hpp	100.00% <0.00%> (ø)
include/seqan3/range/views/rank_to.hpp	100.00% <0.00%> (ø)
include/seqan3/search/search_result.hpp	100.00% <0.00%> (ø)
... and 44 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcbeb8...11e8cf0. Read the comment docs.