[MISC] rename align_cfg::vectorise to align_cfg::vectorised #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvdtoorn
requested review from
a team and
eseiler
and removed request for
a team
|
Closed and reopened to trigger jenkins after status 'aborted'. |
eseiler
approved these changes
Aug 12, 2020
CHANGELOG.md
Outdated
| @@ -84,6 +84,7 @@ Note that 3.1.0 will be the first API stable release and interfaces in this rele | |||
| * The seqan3::align_cfg::mode configuration has been adapted. The algorithm can now be configured using one of the | |||
| pipeable configuration elements seqan3::align_cfg::method_global or seqan3::align_cfg::method_local | |||
| ([\#1918](https://github.com/seqan/seqan3/pull/1918). | |||
| * The seqan3::align_cfg::vectorise configuration is now renamed to seqan3::align_cfg::vectorised. | |||
There was a problem hiding this comment.
Suggested change
| * The seqan3::align_cfg::vectorise configuration is now renamed to seqan3::align_cfg::vectorised. | |
| * The seqan3::align_cfg::vectorise configuration has been renamed to seqan3::align_cfg::vectorised. |
| @@ -72,7 +72,7 @@ namespace seqan3 | |||
| * | |||
| * For each sequence pair one or more \ref seqan3::alignment_result "seqan3::alignment_result"s can be computed. | |||
| * The seqan3::align_pairwise function returns an seqan3::algorithm_result_generator_range which can be used to iterate over the | |||
There was a problem hiding this comment.
Can you fix the line length here while you're changing the file anyway?
Jenkins nodes seem to be down. |
marehr
approved these changes
Aug 12, 2020
|
@smehringer, @rrahn Ups, didn't see that you weren't assigned by |
Yes, that's right. Should I change the commit message/changelog entry? |
|
jenkins is working again and pointed out a documentation reference that I missed, fixed. |
Codecov Report
@@ Coverage Diff @@
## release-3.0.2 #2026 +/- ##
==============================================
Coverage 97.89% 97.89%
==============================================
Files 262 263 +1
Lines 9863 9879 +16
==============================================
+ Hits 9655 9671 +16
Misses 208 208
Continue to review full report at Codecov.
|
|
Looks good 👍 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes seqan/product_backlog#178.