[FEATURE] counting_agent for the interleaved bloom filter #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseiler
force-pushed
the
feature/counting_agent
branch
from
015c8ed
to
f82bc55
Compare
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 265 265
Lines 10806 10820 +14
=======================================
+ Hits 10613 10627 +14
Misses 193 193
Continue to review full report at Codecov.
|
smehringer
reviewed
Feb 11, 2021
|
|
||
| /*!\brief Returns a seqan3::interleaved_bloom_filter::counting_agent_type to be used for counting. | ||
| * \attention Calling seqan3::interleaved_bloom_filter::increase_bin_number_to invalidates all | ||
| * seqan3::interleaved_bloom_filter::counting_agent_type constructed for this Interleaved Bloom Filter. |
There was a problem hiding this comment.
Suggested change
| * seqan3::interleaved_bloom_filter::counting_agent_type constructed for this Interleaved Bloom Filter. | |
| * `seqan3::interleaved_bloom_filter::counting_agent_type`s constructed for this Interleaved Bloom Filter. |
| * each thread. | ||
| */ | ||
| template <std::ranges::range value_range_t> | ||
| [[nodiscard]] counting_vector<value_t> const & count_values(value_range_t && values) & noexcept |
There was a problem hiding this comment.
just a thing to think about:
Since the memberhip_agent has the function bulk_contains we might want to consider naming this function
bulk_count.
eseiler
force-pushed
the
feature/counting_agent
branch
from
f82bc55
to
b03ae10
Compare
eseiler
requested review from
a team,
SGSSGene and
Irallia
and removed request for
a team and
SGSSGene
Irallia
approved these changes
Feb 12, 2021
eseiler
force-pushed
the
feature/counting_agent
branch
from
b03ae10
to
de48037
Compare
eseiler
force-pushed
the
feature/counting_agent
branch
from
de48037
to
1184056
Compare
SGSSGene
approved these changes
Feb 14, 2021
eseiler
force-pushed
the
feature/counting_agent
branch
2 times, most recently
from
1bcedd3
to
cd510f7
Compare
marehr
approved these changes
Feb 15, 2021
| return result_buffer; | ||
| } | ||
|
|
||
| // `bulk_count` cannot be called on a temporary, since the object the returned reference points to |
There was a problem hiding this comment.
Interesting that we don't need any !\brief here
Comment on lines
14
to
16
| auto const sequence_1 = "ACTGACTGACTGATC"_dna4; | ||
| auto const sequence_2 = "GTGACTGACTGACTCG"_dna4; | ||
| auto const sequence_3 = "AAAAAAACGATCGACA"_dna4; |
There was a problem hiding this comment.
Suggested change
| auto const sequence_1 = "ACTGACTGACTGATC"_dna4; | |
| auto const sequence_2 = "GTGACTGACTGACTCG"_dna4; | |
| auto const sequence_3 = "AAAAAAACGATCGACA"_dna4; | |
| auto const sequence1 = "ACTGACTGACTGATC"_dna4; | |
| auto const sequence2 = "GTGACTGACTGACTCG"_dna4; | |
| auto const sequence3 = "AAAAAAACGATCGACA"_dna4; |
No hard-feelings for this change, but I think we normally don't underscore before numbers.
eseiler
force-pushed
the
feature/counting_agent
branch
from
cd510f7
to
a1b1e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1911 (comment)