Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] author and email not showing in argument_parser #2374

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Feb 11, 2021

Resolves #2173

@eseiler eseiler requested review from a team and eaasna and removed request for a team February 11, 2021 15:00
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #2374 (59a2a82) into master (03c4a17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files         266      266           
  Lines       10835    10843    +8     
=======================================
+ Hits        10642    10650    +8     
  Misses        193      193           
Impacted Files Coverage Δ
...lude/seqan3/argument_parser/detail/format_base.hpp 92.72% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c4a17...789e44a. Read the comment docs.

@eseiler eseiler force-pushed the fix/print_meta branch 2 times, most recently from 13c4ce1 to e6e6ef8 Compare February 12, 2021 19:48
Copy link
Contributor

@eaasna eaasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@eseiler eseiler requested a review from marehr February 17, 2021 07:53
@marehr
Copy link
Member

marehr commented Feb 17, 2021

(You need to resolve the merge conflict)

@eseiler eseiler merged commit 46b4364 into seqan:master Feb 17, 2021
@eseiler eseiler deleted the fix/print_meta branch May 14, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument parser wrong copyright year and missing metadata
3 participants