Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cigar operation #2388

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Cigar operation #2388

merged 2 commits into from
Mar 15, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Feb 17, 2021 •
edited

@vercel
Copy link

vercel bot commented Feb 17, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/2LEeQHabL75AhAq6enW8CKhh7UZX
✅ Preview: https://seqan3-git-fork-marehr-cigaroperation-seqan.vercel.app

@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited

Codecov Report

Merging #2388 (bf6e676) into master (2323836) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         266      266           
  Lines       10928    10928           
=======================================
  Hits        10736    10736           
  Misses        192      192
Impacted Files Coverage Δ
include/seqan3/alphabet/cigar/cigar.hpp 91.30% <ø> (ø)
include/seqan3/argument_parser/validators.hpp 92.30% <100.00%> (ø)
include/seqan3/io/record.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2323836...4ff91ca. Read the comment docs.

@marehr marehr requested review from a team and eaasna and removed request for a team March 11, 2021 13:14
@marehr marehr marked this pull request as ready for review March 11, 2021 13:15
@eseiler eseiler requested review from a team and MitraDarja and removed request for eaasna and a team March 11, 2021 18:31
MitraDarja
MitraDarja requested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@MitraDarja MitraDarja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One really minor thing, otherwise it lgtm. :)

CHANGELOG.md Outdated
@@ -88,8 +88,13 @@ If possible, provide tooling that performs the changes, e.g. a shell-script.

#### Alphabet

* Removed seqan3::char_is_valid_for requirement from seqan3::writable_alphabet and seqan3::writable_constexpr_alphabet
* Removed seqan3::char_is_valid_for requirement from seqan3::detail::writable_alphabet and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks like it would belong to a different PR? Or did you just fix this because you touched the file already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just corrected a changelog entry (but the wrong one 🙈), if you want, I can create a new PR to fix it there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that is not necessary. Just wanted to make sure, that this was on purpose and not an accident. ;)
But, this is still shown as a change? (I think because there is a new line that is not in the master branch?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added detail:: and needed to wrap the line, as it exceeded our line limit :)

marehr
marehr commented Mar 12, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
marehr
marehr commented Mar 12, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@marehr marehr requested a review from MitraDarja March 12, 2021 13:35
MitraDarja
MitraDarja requested changes Mar 12, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@marehr marehr requested a review from MitraDarja March 12, 2021 14:47
@MitraDarja MitraDarja requested a review from eseiler March 12, 2021 16:16
@eseiler eseiler merged commit 5303d2e into seqan:master Mar 15, 2021
@marehr marehr deleted the cigar_operation branch March 17, 2021 15:58
SGSSGene pushed a commit to SGSSGene/seqan3 that referenced this pull request Mar 18, 2021
@marehr @SGSSGene
Cigar operation (seqan#2388)
4b5315f 
* [MISC] deprecate seqan3::cigar_op and add changelog

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler approved these changes

@MitraDarja MitraDarja MitraDarja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make seqan3::cigar_op part of seqan3::cigar::operation
3 participants
@marehr @eseiler @MitraDarja