[MISC] rename seqan3::{alignment => sam}_file_output* #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
requested review from
a team and
Irallia
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/DaFzC63zVAzRdS99gJEVdTLxBEdn |
Codecov Report
@@ Coverage Diff @@
## master #2414 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 267 267
Lines 10863 10863
=======================================
Hits 10669 10669
Misses 194 194
Continue to review full report at Codecov.
|
Irallia
requested changes
Mar 1, 2021
Comment on lines
812
to
815
| sam_file_output(std::filesystem::path, selected_field_ids const &) | ||
| -> sam_file_output<selected_field_ids, | ||
| typename sam_file_output<>::valid_formats, | ||
| ref_info_not_given>; |
There was a problem hiding this comment.
Suggested change
| sam_file_output(std::filesystem::path, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, | |
| typename sam_file_output<>::valid_formats, | |
| ref_info_not_given>; | |
| sam_file_output(std::filesystem::path, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, typename sam_file_output<>::valid_formats, ref_info_not_given>; |
Comment on lines
823
to
826
| sam_file_output(stream_type &&, file_format const &, selected_field_ids const &) | ||
| -> sam_file_output<selected_field_ids, | ||
| type_list<file_format>, | ||
| ref_info_not_given>; |
There was a problem hiding this comment.
Suggested change
| sam_file_output(stream_type &&, file_format const &, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, | |
| type_list<file_format>, | |
| ref_info_not_given>; | |
| sam_file_output(stream_type &&, file_format const &, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, type_list<file_format>, ref_info_not_given>; |
Comment on lines
834
to
837
| sam_file_output(stream_type &, file_format const &, selected_field_ids const &) | ||
| -> sam_file_output<selected_field_ids, | ||
| type_list<file_format>, | ||
| ref_info_not_given>; |
There was a problem hiding this comment.
Suggested change
| sam_file_output(stream_type &, file_format const &, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, | |
| type_list<file_format>, | |
| ref_info_not_given>; | |
| sam_file_output(stream_type &, file_format const &, selected_field_ids const &) | |
| -> sam_file_output<selected_field_ids, type_list<file_format>, ref_info_not_given>; |
Comment on lines
843
to
847
| sam_file_output_format file_format> | ||
| sam_file_output(stream_type &&, file_format const &) | ||
| -> sam_file_output<typename sam_file_output<>::selected_field_ids, | ||
| type_list<file_format>, | ||
| ref_info_not_given>; |
Comment on lines
854
to
857
| sam_file_output(stream_type &, file_format const &) | ||
| -> sam_file_output<typename sam_file_output<>::selected_field_ids, | ||
| type_list<file_format>, | ||
| ref_info_not_given>; |
Comment on lines
899
to
902
| sam_file_output(stream_type &&, ref_ids_type &&, ref_lengths_type &&, file_format const &) | ||
| -> sam_file_output<typename sam_file_output<>::selected_field_ids, | ||
| type_list<file_format>, | ||
| std::remove_reference_t<ref_ids_type>>; |
There was a problem hiding this comment.
Suggested change
| sam_file_output(stream_type &&, ref_ids_type &&, ref_lengths_type &&, file_format const &) | |
| -> sam_file_output<typename sam_file_output<>::selected_field_ids, | |
| type_list<file_format>, | |
| std::remove_reference_t<ref_ids_type>>; | |
| sam_file_output(stream_type &&, ref_ids_type &&, ref_lengths_type &&, file_format const &) | |
| -> sam_file_output<typename sam_file_output<>::selected_field_ids, | |
| type_list<file_format>, | |
| std::remove_reference_t<ref_ids_type>>; |
|
@Irallia ty good catch :) |
eseiler
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of many small rename PRs, tackles seqan/product_backlog#290.