-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Rename views::get to views::elements #2554
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/HZm3cwDpEAgLkHQH8FY1CT27GV7n |
57eba1e
to
0e1f4d5
Compare
0e1f4d5
to
423c895
Compare
Codecov Report
@@ Coverage Diff @@
## master #2554 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 269 269
Lines 10539 10539
=======================================
Hits 10353 10353
Misses 186 186
Continue to review full report at Codecov.
|
423c895
to
12956e4
Compare
12956e4
to
57a5098
Compare
57a5098
to
c4b98d0
Compare
c4b98d0
to
967c339
Compare
967c339
to
f104911
Compare
f104911
to
f324ac6
Compare
f324ac6
to
1dc0059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one include missing, but I'll already aprove.
The rest LGFM, thank you!
Resolves seqan/product_backlog#326
std::views::elements
is not implemented in range-v3https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100233