Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Rename views::get to views::elements #2554

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 23, 2021

Resolves seqan/product_backlog#326

std::views::elements is not implemented in range-v3

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100233

@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/HZm3cwDpEAgLkHQH8FY1CT27GV7n
✅ Preview: https://seqan3-git-fork-eseiler-misc-deprecateget-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2554 (6010d83) into master (b6938d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2554   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10539    10539           
=======================================
  Hits        10353    10353           
  Misses        186      186           
Impacted Files Coverage Δ
.../seqan3/alignment/pairwise/alignment_algorithm.hpp 100.00% <100.00%> (ø)
...t/pairwise/detail/pairwise_alignment_algorithm.hpp 98.73% <100.00%> (ø)
...ise/detail/pairwise_alignment_algorithm_banded.hpp 100.00% <100.00%> (ø)
include/seqan3/io/sequence_file/output.hpp 100.00% <100.00%> (ø)
include/seqan3/io/structure_file/output.hpp 100.00% <100.00%> (ø)
include/seqan3/utility/views/elements.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6938d2...6010d83. Read the comment docs.

@eseiler eseiler requested review from a team and Irallia and removed request for a team April 27, 2021 12:30
Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one include missing, but I'll already aprove.
The rest LGFM, thank you!

@Irallia Irallia requested review from a team and marehr and removed request for a team April 27, 2021 14:08
@marehr marehr enabled auto-merge (squash) April 28, 2021 09:41
@marehr marehr merged commit c30c81b into seqan:master Apr 28, 2021
@eseiler eseiler deleted the misc/deprecate_get branch May 14, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate seqan3::views::get
3 participants