Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] deprecate seqan3::views::to_lower #2556

Merged
merged 1 commit into from
Apr 23, 2021
Merged

[MISC] deprecate seqan3::views::to_lower #2556

merged 1 commit into from
Apr 23, 2021

Conversation

MitraDarja
Copy link
Contributor

@vercel
Copy link

vercel bot commented Apr 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/8YoSPwrQxYEuZ4qZhZVHJCfJi3wG
✅ Preview: https://seqan3-git-fork-mitradarja-tolower-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 23, 2021 •
edited
Loading

Codecov Report

Merging #2556 (1fb2a37) into master (dca7146) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10541    10541           
=======================================
  Hits        10355    10355           
  Misses        186      186
Impacted Files Coverage Δ
include/seqan3/range/views/to_lower.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca7146...1fb2a37. Read the comment docs.

@MitraDarja MitraDarja requested review from a team and Irallia and removed request for a team April 23, 2021 13:00
Irallia
Irallia approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, thank you!

@marehr marehr requested review from a team and marehr and removed request for a team April 23, 2021 13:42
@marehr marehr merged commit 128d398 into seqan:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marehr marehr marehr approved these changes

@Irallia Irallia Irallia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate seqan3::views::to_lower
3 participants
@MitraDarja @marehr @Irallia