Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Rename seqan3::translation_frames::*FRAMES* #2565

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

simonsasse
Copy link
Member

@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/BVnMgeXL9kCKd4BX5H383GwLWC5o
✅ Preview: https://seqan3-git-fork-simonsasse-lowercasetranslationframes-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #2565 (e820738) into master (e6c9df9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e820738 differs from pull request most recent head 19b59e5. Consider uploading reports for the commit 19b59e5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2565   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10549    10551    +2     
=======================================
+ Hits        10363    10365    +2     
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/range/views/translate.hpp 100.00% <100.00%> (ø)
include/seqan3/range/views/translate_join.hpp 100.00% <100.00%> (ø)
.../seqan3/range/container/concatenated_sequences.hpp 96.84% <0.00%> (-0.07%) ⬇️
include/seqan3/io/record.hpp 100.00% <0.00%> (ø)
include/seqan3/range/views/move.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/cigar/cigar.hpp 91.30% <0.00%> (ø)
include/seqan3/range/views/as_const.hpp 100.00% <0.00%> (ø)
include/seqan3/io/sam_file/format_bam.hpp 96.29% <0.00%> (ø)
include/seqan3/io/sam_file/format_sam.hpp 97.44% <0.00%> (ø)
include/seqan3/io/sequence_file/input.hpp 100.00% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c9df9...19b59e5. Read the comment docs.

@simonsasse simonsasse requested a review from eseiler April 27, 2021 11:17
@eseiler eseiler requested review from a team and MitraDarja and removed request for eseiler and a team April 27, 2021 12:04
@MitraDarja MitraDarja requested a review from eseiler April 27, 2021 12:16
CHANGELOG.md Outdated Show resolved Hide resolved
include/seqan3/range/views/translate.hpp Outdated Show resolved Hide resolved
test/snippet/range/views/translate_dna5.cpp Outdated Show resolved Hide resolved
test/unit/range/views/translate_join_test.cpp Outdated Show resolved Hide resolved
@simonsasse
Copy link
Member Author

Applied review and rebased. :)

Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed some frames in the test

@eseiler eseiler force-pushed the lower_case_translation_frames branch from f568a60 to 19b59e5 Compare April 29, 2021 15:04
@eseiler eseiler enabled auto-merge April 29, 2021 15:05
@eseiler eseiler changed the title [MISC] Lower case seqan3::translation_frames::*FRAME* and deprecate the uppercase versions. [MISC] Rename seqan3::translation_frames::*FRAMES* Apr 29, 2021
@simonsasse
Copy link
Member Author

sorry I messed up the rebase and had no time to fully fix it yet. Thanks for helping out ! :)

@eseiler eseiler merged commit 42ae7d1 into seqan:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

translate: lower case translation_frames constants
3 participants