Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] deprecate seqan3::views::as_const #2567

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Apr 27, 2021

@marehr marehr requested review from a team and MitraDarja and removed request for a team April 27, 2021 13:12
@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/5c4ToPFaCbBfgBtrsaeg2ArTDFeN
✅ Preview: https://seqan3-git-fork-marehr-deprecateasconst-seqan.vercel.app

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #2567 (18479d3) into master (5cd019b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2567   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10539    10543    +4     
=======================================
+ Hits        10353    10357    +4     
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/range/views/as_const.hpp 100.00% <ø> (ø)
.../seqan3/range/container/concatenated_sequences.hpp 96.90% <100.00%> (+0.06%) ⬆️
include/seqan3/range/decorator/gap_decorator.hpp 100.00% <0.00%> (ø)
include/seqan3/range/views/single_pass_input.hpp
include/seqan3/range/views/translate_join.hpp
include/seqan3/range/views/get.hpp
include/seqan3/range/views/translate.hpp
include/seqan3/utility/views/elements.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/views/translate_join.hpp 100.00% <0.00%> (ø)
include/seqan3/alphabet/views/translate.hpp 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd019b...18479d3. Read the comment docs.

@MitraDarja MitraDarja requested a review from eseiler April 27, 2021 14:28
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 + ❔

CHANGELOG.md Outdated Show resolved Hide resolved
include/seqan3/range/container/concatenated_sequences.hpp Outdated Show resolved Hide resolved
include/seqan3/range/views/as_const.hpp Show resolved Hide resolved
test/unit/range/views/as_const_test.cpp Show resolved Hide resolved
Co-authored-by: Enrico Seiler <eseiler@users.noreply.github.com>
@eseiler eseiler merged commit 1f21a9d into seqan:master Apr 28, 2021
@marehr marehr deleted the deprecate_as_const branch April 28, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate seqan3::views::as_const
3 participants