Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap meaning of is_alternative and holds_alternative #2596

Merged
merged 4 commits into from
May 5, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented May 4, 2021

@eseiler eseiler requested review from a team and SGSSGene and removed request for a team May 4, 2021 10:59
@vercel
Copy link

vercel bot commented May 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/GQFzu1fZqNTFyPnV8EZDfugrvncJ
✅ Preview: https://seqan3-git-fork-eseiler-misc-variant-seqan.vercel.app

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SGSSGene SGSSGene requested review from a team and marehr and removed request for a team May 4, 2021 12:38
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2596 (8b70ee7) into master (8eeab86) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2596   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         271      271           
  Lines       10623    10623           
=======================================
  Hits        10437    10437           
  Misses        186      186           
Impacted Files Coverage Δ
...ude/seqan3/alphabet/composite/alphabet_variant.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eeab86...8b70ee7. Read the comment docs.

@eseiler eseiler deleted the misc/variant branch May 14, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch meaning of seqan3::alphabet_variant::{is_alternative, holds_alternative}
3 participants