Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] seqan3::views::single_pass_input::iterator::operator++(int) must return void (real cxx20 std::input_iterator) #2775

Merged
merged 7 commits into from
Aug 24, 2021
Merged

[FIX] seqan3::views::single_pass_input::iterator::operator++(int) must return void (real cxx20 std::input_iterator) #2775

merged 7 commits into from
Aug 24, 2021

Commits on Aug 24, 2021

  1. [FIX] take_until_view: post-increment should return void if underlyin… 

    …g iterator returns void
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b21a560 View commit details
    Browse the repository at this point in the history

  2. [FIX] take_exactly_view: post-increment should return void if underly… 

    …ing iterator returns void
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    7b673a5 View commit details
    Browse the repository at this point in the history

  3. [FIX] seqan3::views::single_pass_input::iterator::operator++(int) mus… 

    …t return void (real cxx20 std::input_iterator)

https://github.com/rrahn/seqan3/blame/939bea75ab00f254ac0c172506f761a2ff6f51eb/include/seqan3/range/view/single_pass_input.hpp#L262-L272

added this change; it is broken, because the semantic of output_iterator can't be fulfilled
`*it++ = value` should have the same semantic as `*i = value; ++i`, but it currently has `++i; *i = value`.
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    6d83bee View commit details
    Browse the repository at this point in the history

  4. [TEST] seqan3::views::single_pass_input::iterator::operator++(int) mu… 

    …st return void (real cxx20 std::input_iterator)
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    bf54833 View commit details
    Browse the repository at this point in the history

  5. [TEST] seqan3::views::single_pass_input::iterator::operator++(int) mu… 

    …st return void (real cxx20 std::input_iterator)
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b3cc007 View commit details
    Browse the repository at this point in the history

  6. [TEST] seqan3::views::single_pass_input::iterator::operator++(int) mu… 

    …st return void (real cxx20 std::input_iterator)
    @marehr @eseiler
    marehr authored and eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    3aefbb9 View commit details
    Browse the repository at this point in the history

  7. [DOC] seqan3::views::single_pass_input returned range loses std::rang… 

    …es::output_range
    @eseiler
    eseiler committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d9b0405 View commit details
    Browse the repository at this point in the history