New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] relax seqan3::views::to_simd requirements to be C++20 compatible #2849
Conversation
``` /seqan3/test/unit/utility/simd/views/to_simd_test.cpp:349:48: required from ‘void view_to_simd_test_issue_1813_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = std::tuple<std::deque<seqan3::dna4, std::allocator<seqan3::dna4> >, __vector(1) signed char>]’ /seqan3/test/unit/utility/simd/views/to_simd_test.cpp:326:1: required from here /seqan3/include/seqan3/utility/simd/views/to_simd.hpp:67:24: error: static assertion failed: Expects the inner range to be default constructible. 67 | static_assert(std::default_initializable<std::ranges::range_value_t<urng_t>>, | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /seqan3/include/seqan3/utility/simd/views/to_simd.hpp:67:24: note: ‘default_initializable<std::ranges::take_view<std::ranges::ref_view<std::deque<seqan3::dna4, std::allocator<seqan3::dna4> > > > >’ evaluates to false /seqan3/include/seqan3/utility/simd/views/to_simd.hpp:67:24: note: constraints not satisfied In file included from /opt/gcc/gcc-git/include/c++/12.0.0/compare:39, from /opt/gcc/gcc-git/include/c++/12.0.0/bits/stl_pair.h:65, from /opt/gcc/gcc-git/include/c++/12.0.0/bits/stl_algobase.h:64, from /opt/gcc/gcc-git/include/c++/12.0.0/memory:63, from /seqan3-build/gcc-git-debug-std20/_deps/gtest_fetch_content-src/googletest/include/gtest/gtest.h:57, from /seqan3/test/unit/utility/simd/views/to_simd_test.cpp:8: /opt/gcc/gcc-git/include/c++/12.0.0/concepts:138:13: required for the satisfaction of ‘constructible_from<_Tp>’ [with _Tp = std::ranges::take_view<std::ranges::ref_view<std::deque<seqan3::dna4, std::allocator<seqan3::dna4> > > >] /opt/gcc/gcc-git/include/c++/12.0.0/concepts:139:30: note: the expression ‘is_constructible_v<_Tp, _Args ...> [with _Tp = std::ranges::take_view<std::ranges::ref_view<std::deque<seqan3::dna4, std::allocator<seqan3::dna4> > > >; _Args = {}]’ evaluated to ‘false’ 139 | = destructible<_Tp> && is_constructible_v<_Tp, _Args...>; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/BBvzHdtEmBkFGduXP8GpmxmBzKa2 |
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 277 277
Lines 10963 10963
=======================================
Hits 10785 10785
Misses 178 178
Continue to review full report at Codecov.
|
@remyschwab If you need help to understand this, we can meet up :) |
Part of seqan/product_backlog#403