Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing ranges::to with a custom minimal implementation #2969

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

SGSSGene
Copy link
Contributor

@SGSSGene SGSSGene commented Apr 27, 2022

Follow-up: seqan/product_backlog#420

Replace ranges::to with a minimal custom implementation seqan3::ranges::to

Todo:

  • Improve Documentation (ranges::to should have 4 entries, but only has 2)
  • cleanup commits
  • Add Changelog
  • Add example
  • fix MacOS :/ (not caused by this PR)

Part of seqan/product_backlog#124

-A Life Without range-v3-

@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 1:30PM (UTC)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2969 (aa7314a) into master (3034678) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
+ Coverage   98.20%   98.21%   +0.01%     
==========================================
  Files         274      275       +1     
  Lines       12220    12244      +24     
==========================================
+ Hits        12001    12026      +25     
+ Misses        219      218       -1     
Impacted Files Coverage Δ
include/seqan3/io/sam_file/format_sam.hpp 95.65% <100.00%> (ø)
include/seqan3/io/structure_file/format_vienna.hpp 97.56% <100.00%> (+0.03%) ⬆️
...nclude/seqan3/utility/container/dynamic_bitset.hpp 99.03% <100.00%> (+<0.01%) ⬆️
include/seqan3/utility/range/to.hpp 100.00% <100.00%> (ø)
include/seqan3/utility/parallel/detail/latch.hpp 96.55% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3034678...aa7314a. Read the comment docs.

@SGSSGene SGSSGene marked this pull request as ready for review May 18, 2022 11:59
@SGSSGene SGSSGene changed the title [DRAFT] replacing ranges::to with a custom minimal implementation replacing ranges::to with a custom minimal implementation May 23, 2022
@SGSSGene SGSSGene changed the title replacing ranges::to with a custom minimal implementation Replacing ranges::to with a custom minimal implementation May 23, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 31, 2022
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Jun 3, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 3, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 3, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 3, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 7, 2022
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 7, 2022
@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Jun 7, 2022
@eseiler eseiler removed the request for review from smehringer June 8, 2022 09:13
@eseiler eseiler merged commit 39e6968 into seqan:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants