[FIX] Write BAM header on sam_file deconstruction if not written before

[smehringer]

Resolves #2497

Now, just opening a seqan3::sam_file_output, e.g. :

seqan3::sam_file_output fout{"test.sam"};

will trigger writing a minimal header on deconstruction.

This also has the implication that

{
   seqan3::sam_file_output fout{"test.bam"}; 
} // Error: BAM file cannot write header

will always raise an exception because without reference information no header can be written.
Reference information must be provided, e.g. via

seqan3::sam_file_output fout{"test.bam", ref_ids, ref_lengths}; // BAM file

or records must be pushed that have a header available, as is the case when piping

seqan3::sam_file_output{"test.sam"} | seqan3::sam_file_output{"test.bam"}; 

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
seqan3	✅ Ready (Inspect)	Visit Preview	Oct 31, 2022 at 2:43PM (UTC)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@07c9fec). Click here to learn what that means.
Patch coverage: 96.20% of modified lines in pull request are covered.

❗ Current head 100da3c differs from pull request most recent head fe51c42. Consider uploading reports for the commit fe51c42 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #3081   +/-   ##
=========================================
  Coverage          ?   98.24%           
=========================================
  Files             ?      276           
  Lines             ?    12361           
  Branches          ?        0           
=========================================
  Hits              ?    12144           
  Misses            ?      217           
  Partials          ?        0           

Impacted Files	Coverage Δ
include/seqan3/io/sam_file/format_sam.hpp	95.65% <ø> (ø)
include/seqan3/io/sam_file/format_bam.hpp	95.42% <95.23%> (ø)
...lude/seqan3/io/sam_file/detail/format_sam_base.hpp	97.97% <95.65%> (ø)
include/seqan3/io/sam_file/output.hpp	100.00% <100.00%> (ø)
...clude/seqan3/io/sam_file/output_format_concept.hpp	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[eseiler]

This time appliable :)
Previous review was on first commit

[eseiler]

GCC 10 doesn't have std::ostringstream::view() :(
Not sure if it would be worth it to use str() for gcc 10 and view() otherwise.
Would be nice to get rid of the string copy, I guess. And we would not miss this optimization opportunity once we drop GCC 10 (if I/O stays until then).

[eseiler]

Added a commit for using str() on GCC 10 and view() otherwise

[eseiler]

There are two ope suggestions for code comments. After that, we could rebase? :D

[Irallia]

LGFM, just one little thing I stumbled across. But it's not very important.