[FEATURE] IBF decompression #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportBase: 98.23% // Head: 98.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3082 +/- ##
==========================================
- Coverage 98.23% 98.22% -0.01%
==========================================
Files 275 275
Lines 12197 12203 +6
==========================================
+ Hits 11982 11987 +5
- Misses 215 216 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eseiler
force-pushed
the
feature/ibf_ctor
branch
from
6dc0767
to
c771ed4
Compare
seqan-actions
added
lint
eseiler
requested review from
a team,
MitraDarja and
remyschwab
and removed request for
a team and
MitraDarja
eseiler
force-pushed
the
feature/ibf_ctor
branch
from
c771ed4
to
c16dc5e
Compare
seqan-actions
added
lint
Irallia
requested review from
a team and
smehringer
and removed request for
a team
smehringer
reviewed
Nov 2, 2022
Comment on lines
246
to
247
| * \attention This constructor can only be used to construct **uncompressed** Interleaved Bloom Filters. | ||
| * |
There was a problem hiding this comment.
Suggested change
| * \attention This constructor can only be used to construct **uncompressed** Interleaved Bloom Filters. | |
| * | |
| * \attention This constructor can only be used to construct **uncompressed** Interleaved Bloom Filters (IBFs). | |
| * Construction of compressed from compressed IBFs is trivial and handled by different constructors. | |
| * |
There was a problem hiding this comment.
or similar.
otherwise you might think it is not possible
There was a problem hiding this comment.
Maybe it's best to remove that \attention completely?
Co-authored-by: Svenja Mehringer <svenja.mehringer@gmail.com>
eseiler
commented
Nov 2, 2022
smehringer
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.