Add storage/kdtree #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 71.60% 76.33% +4.72%
==========================================
Files 17 18 +1
Lines 789 883 +94
==========================================
+ Hits 565 674 +109
+ Misses 191 176 -15
Partials 33 33
Continue to review full report at Codecov.
|
6 tasks
f-fl0
approved these changes
Oct 8, 2021
pc/storage/kdtree/kdtree.go
Outdated
|
|
||
| var left, right *node | ||
| if mid > 0 { | ||
| left = newNode(ra, indice[0:mid], depth+1) |
There was a problem hiding this comment.
[optional] Maybe it is better to be explicit but indice[0:mid] could just be indice[:mid] I believe.
pc/storage/kdtree/kdtree.go
Outdated
| left = newNode(ra, indice[0:mid], depth+1) | ||
| } | ||
| if mid+1 < len(indice) { | ||
| right = newNode(ra, indice[mid+1:len(indice)], depth+1) |
There was a problem hiding this comment.
[optional] Same here for indice[mid+1:len(indice)]. It could be indice[mid+1:]
pc/storage/kdtree/kdtree_test.go
Outdated
| it.SetVec3(mat.Vec3{1, 0, 0}) // 5 | ||
| it.Incr() | ||
| it.SetVec3(mat.Vec3{6, 2, 1}) // 6 | ||
| it.Incr() |
There was a problem hiding this comment.
I think the call to it.Incr() is not necessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to use it for ICP registration.