Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and add integration test #16

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Fix CI and add integration test #16

merged 4 commits into from
Sep 25, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Sep 25, 2020

No description provided.

@at-wat at-wat self-assigned this Sep 25, 2020
@at-wat at-wat requested a review from t-asaka September 25, 2020 00:25
@at-wat
Copy link
Member Author

at-wat commented Sep 25, 2020

@t-asaka please take a look

t-asaka
t-asaka approved these changes Sep 25, 2020
View reviewed changes
Copy link

@t-asaka t-asaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration_test.go Outdated
}
defer nodeSub.Shutdown()

println(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@at-wat at-wat merged commit 98de93d into master Sep 25, 2020
@at-wat at-wat deleted the fix-ci-and-add-integration-test branch September 25, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-asaka t-asaka t-asaka approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@at-wat @t-asaka