Set timestamp of download files #87

at-wat · 2020-10-28T07:55:19Z

codecov · 2020-10-28T07:57:04Z

Codecov Report

Merging #87 into master will decrease coverage by 0.48%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   79.92%   79.44%   -0.49%     
==========================================
  Files           4        4              
  Lines         284      287       +3     
==========================================
+ Hits          227      228       +1     
- Misses         32       33       +1     
- Partials       25       26       +1

Impacted Files	Coverage Δ
s3sync.go	`77.04% <33.33%> (-0.52%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78a44e...0b8fffb. Read the comment docs.

kt3k · 2020-10-28T09:32:07Z

util_test.go

+		t.Error("Failed to get stat:", err)
+		return
+	}
+	if t1 := info.ModTime(); !t1.Before(t0) {


kt3k

Thanks! Looks like a reasonable addition.

at-wat added 2 commits October 28, 2020 16:42

Set file timestamp according to S3 timestamp on download

93de673

Check file timestamp on the test

af92e01

at-wat requested a review from kt3k October 28, 2020 07:57

Tweak format

0b8fffb

at-wat self-assigned this Oct 28, 2020

kt3k reviewed Oct 28, 2020

View reviewed changes

util_test.go

t.Error("Failed to get stat:", err)

return

}

if t1 := info.ModTime(); !t1.Before(t0) {

Copy link

Contributor

kt3k Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kt3k approved these changes Oct 28, 2020

View reviewed changes

kt3k merged commit 2ea0458 into master Oct 28, 2020

kt3k deleted the set-file-timestamp-on-download branch October 28, 2020 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set timestamp of download files #87

Set timestamp of download files #87

at-wat commented Oct 28, 2020

codecov bot commented Oct 28, 2020 •

edited

Loading

kt3k Oct 28, 2020

kt3k left a comment

Set timestamp of download files #87

Set timestamp of download files #87

Conversation

at-wat commented Oct 28, 2020

codecov bot commented Oct 28, 2020 • edited Loading

Codecov Report

kt3k Oct 28, 2020

Choose a reason for hiding this comment

kt3k left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 28, 2020 •

edited

Loading