Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve simulated communication delay #149

Merged
merged 16 commits into from Mar 26, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 25, 2024

Simulated communication delay was inaccurate on some environments due to asynchronous wait on single io_service.
Use synchronous wait on separate threads to fix the accuracy.

urg_stamped/Status message containing internal timestamp estimation status is published.

@at-wat at-wat self-assigned this Mar 25, 2024
@sqbot

This comment has been minimized.

@sqbot

This comment has been minimized.

@sqbot

This comment has been minimized.

@sqbot

This comment has been minimized.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.39%. Comparing base (eb0c348) to head (a78a486).

Files Patch % Lines
src/urg_sim/urg_sim.cpp 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   80.07%   80.39%   +0.32%     
==========================================
  Files          31       31              
  Lines        1270     1301      +31     
==========================================
+ Hits         1017     1046      +29     
- Misses        253      255       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sqbot

This comment has been minimized.

@sqbot

This comment has been minimized.

@at-wat at-wat marked this pull request as ready for review March 26, 2024 03:07
@sqbot

This comment has been minimized.

@sqbot
Copy link
Member

sqbot commented Mar 26, 2024

[177] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
build/test_results/urg_stamped/rostest-test_tests_e2e.xml: 1 tests
build/test_results/urg_stamped/rosunit-e2e.xml: 6 tests
Summary: 50 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat requested a review from Taka-Kazu March 26, 2024 04:19
@at-wat at-wat merged commit 6f2f279 into master Mar 26, 2024
5 checks passed
@at-wat at-wat deleted the improve-simulated-communication-delay branch March 26, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants