Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #36

Merged
merged 9 commits into from
Aug 23, 2018
Merged

Update README #36

merged 9 commits into from
Aug 23, 2018

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Aug 20, 2018 •
edited
Loading

merge after #35
fix #27

@at-wat at-wat self-assigned this Aug 20, 2018
@sqbot

This comment has been minimized.

Sign in to view
@sqbot

This comment has been minimized.

Sign in to view
at-wat
at-wat commented Aug 21, 2018
View reviewed changes
README.md Outdated
- Tested only for UTM-30LX-EW and UST-20LX at now.
- Some scans are dropped due to the clock synchronization and delay estimation.

## Comparizon with urg_node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparison

@sqbot

This comment has been minimized.

Sign in to view
@sqbot

This comment has been minimized.

Sign in to view
@sqbot

This comment has been minimized.

Sign in to view
1 similar comment
@sqbot
Copy link
Member

sqbot commented Aug 21, 2018

PASSED on ROS kinetic

All tests passed

build/test_results/urg_stamped/gtest-test_decode.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 1 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 4 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat changed the title [WIP] Update README Update README Aug 21, 2018
@at-wat
Copy link
Member Author

at-wat commented Aug 21, 2018

@DaikiMaekawa @ykoga-kyutech please take a look

@at-wat
Copy link
Member Author

at-wat commented Aug 21, 2018

(This repository will be public under Apache 2.0 license.)

ykoga-kyutech
ykoga-kyutech approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@ykoga-kyutech ykoga-kyutech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents looks good to me.
Link to the urg_node page (ROS page or github page etc)
and additional API doc(pub/sub/service/param) of this node might be helpful for developers.

@sqbot
Copy link
Member

sqbot commented Aug 21, 2018

PASSED on ROS kinetic

All tests passed

build/test_results/urg_stamped/gtest-test_decode.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 1 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 4 tests, 0 errors, 0 failures, 0 skipped

@at-wat
Copy link
Member Author

at-wat commented Aug 21, 2018

@ykoga-kyutech API doc has been added. PTAL

@ykoga-kyutech
Copy link
Contributor

@at-wat lgtm 👍

@DaikiMaekawa
Copy link

👍 LGTM

@sqbot
Copy link
Member

sqbot commented Aug 23, 2018 •
edited
Loading

[#93] PASSED on ROS melodic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 2 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 1 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 12 tests, 0 errors, 0 failures, 0 skipped

[#93] PASSED on ROS kinetic

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 2 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 1 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 12 tests, 0 errors, 0 failures, 0 skipped

[#93] PASSED on ROS indigo

All tests passed 
build/test_results/urg_stamped/gtest-test_decode.xml: 2 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 3 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 2 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 1 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 12 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat merged commit 847aa37 into master Aug 23, 2018
@at-wat at-wat deleted the update-readme branch August 23, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaikiMaekawa DaikiMaekawa DaikiMaekawa approved these changes

@ykoga-kyutech ykoga-kyutech ykoga-kyutech approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example data of timestamp variance
4 participants
@at-wat @sqbot @ykoga-kyutech @DaikiMaekawa